Add Warning Check to Evaluate Total Field amount in Structs #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mgmilton
force-pushed
the
add-struct-field-checker
branch
from
c1c6c33 to
a59bd22
Compare
|
Hi, I like the idea behind this check. Will try to review as soon as I can 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Warning Check that evaluates structs to check to see if they contain a reasonable number of fields. Structs are stored as flat maps if they have fewer than 32 fields. However, the Erlang VM stores structs with greater than 32 fields as hash maps. This can potentially lead to bloating and higher memory usage.
Structs with more than 32 fields are considered an anti-pattern in the official Elixir documentation.